pallet-assets ERC20 precompile by pgherveou · Pull Request #8554 · paritytech/polkadot-sdk

pgherveou · 2025-05-16T13:58:52Z

Add ERC20 precompile for pallet-asset.

Since there can be multiple instances of pallet-assets, the Precompile is implemented for an AssetPrecompileConfig that defines both the address range to match and how to extract the asset_id from the address.

For now I have only created one AssetIdExtractor that pulls an u32 asset id encoded in the address.

Follow up PR will define stateful extractor to extract the id from storage for foreign assets.

Other solidity traits will be added in follow up PRs

pgherveou · 2025-05-17T07:47:09Z

/cmd prdoc --audience runtime_dev --bump patch

…time_dev --bump patch'

pgherveou · 2025-05-17T14:39:30Z

/cmd bench --runtime dev --pallet pallet-assets

github-actions · 2025-05-17T14:40:28Z

Command "bench --runtime dev --pallet pallet-assets" has started 🚀 See logs here

github-actions · 2025-05-17T15:09:29Z

Command "bench --runtime dev --pallet pallet-assets" has failed ❌! See logs here

pgherveou · 2025-05-17T20:17:38Z

/cmd bench --runtime dev --pallet pallet_assets

github-actions · 2025-05-17T20:18:33Z

Command "bench --runtime dev --pallet pallet_assets" has started 🚀 See logs here

…--pallet pallet_assets'

github-actions · 2025-05-17T20:47:53Z

Command "bench --runtime dev --pallet pallet_assets" has finished ✅ See logs here

Details

Subweight results:

File	Extrinsic	Old	New	Change [%]
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/snowbridge_pallet_system_frontend.rs	register_token	91.00us	470.00us	+416.48
substrate/frame/assets/src/weights.rs	total_issuance		33.98us	Added
substrate/frame/assets/src/weights.rs	balance		33.87us	Added
substrate/frame/assets/src/weights.rs	allowance		36.63us	Added

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_assets']

paritytech-workflow-stopper · 2025-05-30T09:21:18Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/15343086379
Failed job name: test-linux-stable

* master: omni-node: fix `benchmark pallet` to work with `--runtime` (#8594) Handle and suppress "New unknown `FromSwarm` libp2p event" warning (#8731) Implement detailed logging for XCM failures (#8724) [pallet-revive] contract's nonce starts at 1 (#8734) sync/fix: Clear gap sync on known imported blocks (#8445) [PoP] Add personhood tracking pallets (#8164) client/net: Use litep2p as the default network backend (#8461) Unflake `returns_status_for_pruned_blocks` (#8709) [AHM] Report the weights of epmb pallet to expose kusama and polkadot weights (#8704) Remove all XCM dependencies from `pallet-revive` (#8584) Docker master image tag fix (#8711) Record ed as part of the storage deposit (#8718) [pallet-revive] update dry-run logic (#8662) feat: add collator peer ID to ParachainInherentData (#8708) Nest errors in pallet-xcm (#7730) pallet-assets ERC20 precompile (#8554) Broker: Introduce min price + adjust renewals to lower market. (#8630) [AHM] Staking async fixes for XCM and election planning (#8422) Staking (EPMB): Add defensive error handling to voter snapshot creation and solution verification (#8687)

Add ERC20 precompile for pallet-asset. Since there can be multiple instances of `pallet-assets`, the Precompile is implemented for an `AssetPrecompileConfig` that defines both the address range to match and how to extract the asset_id from the address. For now I have only created one `AssetIdExtractor` that pulls an u32 asset id encoded in the address. Follow up PR will define stateful extractor to extract the id from storage for foreign assets. Other solidity traits will be added in follow up PRs --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com>

@kianenigma

This brings in `stable2506` Polkadot SDK, and integrates many new features. Integrated breaking changes to be verified by the original authors: - [x] ~paritytech/polkadot-sdk#8127 @kianenigma @Ank4n~ This will come in with AHM, and not before. - [x] paritytech/polkadot-sdk#7597 @gui1117 - [x] paritytech/polkadot-sdk#8254 @bkchr - [x] paritytech/polkadot-sdk#7592 @bkontur - [x] paritytech/polkadot-sdk#8382 @UtkarshBhardwaj007 - [x] paritytech/polkadot-sdk#8021 @serban300 - [x] paritytech/polkadot-sdk#8344 @serban300 - [x] paritytech/polkadot-sdk#8262 @athei - [x] paritytech/polkadot-sdk#8584 @athei - [x] paritytech/polkadot-sdk#8299 @skunert - [x] paritytech/polkadot-sdk#8652 @pgherveou - [x] paritytech/polkadot-sdk#8554 @pgherveou - [x] paritytech/polkadot-sdk#8281 @mrshiposha - [x] paritytech/polkadot-sdk#7730 @franciscoaguirre - [x] paritytech/polkadot-sdk#8599 @yrong @claravanstaden - [x] paritytech/polkadot-sdk#8531 @bkontur - [x] paritytech/polkadot-sdk#8409 @kianenigma - [x] paritytech/polkadot-sdk#9137 @franciscoaguirre - [x] paritytech/polkadot-sdk#7944 @bkontur - [x] paritytech/polkadot-sdk#8179 @bkontur - [x] paritytech/polkadot-sdk#8037 @yrong --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: claravanstaden <claravanstaden64@gmail.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Alain Brenzikofer <alain@integritee.network> Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: ron <yrong1997@gmail.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Overkillus <maciej.zyszkiewicz@parity.io>

Add ERC20 precompile for pallet-asset. Since there can be multiple instances of `pallet-assets`, the Precompile is implemented for an `AssetPrecompileConfig` that defines both the address range to match and how to extract the asset_id from the address. For now I have only created one `AssetIdExtractor` that pulls an u32 asset id encoded in the address. Follow up PR will define stateful extractor to extract the id from storage for foreign assets. Other solidity traits will be added in follow up PRs --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com>

pgherveou added 6 commits May 15, 2025 11:36

wip

1782372

fix

7734e4e

add utility functions

dbe1ba3

update

2327800

wip

4db4984

add tests

0374ba5

pgherveou commented May 16, 2025

View reviewed changes

Comment thread substrate/frame/revive/src/precompiles.rs Outdated

nit

8dc6a8e

pgherveou marked this pull request as ready for review May 16, 2025 21:31

pgherveou requested a review from a team as a code owner May 16, 2025 21:31

fix alloy

2065dcb

pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-no-crate-publish-required The change does not require any crates to be re-published. labels May 17, 2025

Update from github-actions[bot] running command 'prdoc --audience run…

ef08472

…time_dev --bump patch'

pgherveou removed the R0-no-crate-publish-required The change does not require any crates to be re-published. label May 17, 2025

pgherveou added 3 commits May 17, 2025 11:43

fix alloy

79bd9ab

add constants

231387c

fix

6aff60d

undo changes

5b580b0

pgherveou added 3 commits May 17, 2025 17:43

clippy

bf654ec

clippy

b9d3add

taplo

86e590a

Update from github-actions[bot] running command 'bench --runtime dev …

bbe4285

…--pallet pallet_assets'

Update from github-actions[bot] running command 'fmt'

79e5fbb

acatangiu approved these changes May 30, 2025

View reviewed changes

xermicus approved these changes May 30, 2025

View reviewed changes

Comment thread substrate/frame/revive/src/lib.rs Outdated

Merge branch 'master' into pg/assets-precompile

1996d16

athei approved these changes May 30, 2025

View reviewed changes

Comment thread substrate/frame/revive/src/lib.rs Outdated

Comment thread substrate/frame/revive/src/lib.rs Outdated

athei added 2 commits May 30, 2025 15:38

Update substrate/frame/revive/src/lib.rs

8c91c30

Update substrate/frame/revive/src/lib.rs

49799cd

athei enabled auto-merge May 30, 2025 13:47

athei added this pull request to the merge queue May 30, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 30, 2025

franciscoaguirre approved these changes May 30, 2025

View reviewed changes

pgherveou added this pull request to the merge queue May 30, 2025

Merged via the queue into master with commit ae4a242 May 30, 2025
256 of 259 checks passed

pgherveou deleted the pg/assets-precompile branch May 30, 2025 18:15

al3mart mentioned this pull request Jun 2, 2025

🪼 Treasury Flow Application use-inkubator/Ecosystem-Grants#65

Merged

acatangiu mentioned this pull request Jul 16, 2025

Upgrade to Polkadot-SDK stable2506 polkadot-fellows/runtimes#817

Merged

21 tasks

github-actions Bot mentioned this pull request Oct 24, 2025

Update polkadot-sdk from stable2503 to stable2506 moondance-labs/tanssi#1340

Closed

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation Bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

github-project-automation Bot moved this to Todo in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

pgherveou added this to [preview] release tracker Mar 23, 2026

github-project-automation Bot moved this to Todo in [preview] release tracker Mar 23, 2026

github-project-automation Bot moved this from Todo to Done in [preview] release tracker Mar 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pallet-assets ERC20 precompile#8554

pallet-assets ERC20 precompile#8554
pgherveou merged 72 commits intomasterfrom
pg/assets-precompile

pgherveou commented May 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

pgherveou commented May 17, 2025

Uh oh!

pgherveou commented May 17, 2025

Uh oh!

github-actions Bot commented May 17, 2025

Uh oh!

github-actions Bot commented May 17, 2025

Uh oh!

pgherveou commented May 17, 2025

Uh oh!

github-actions Bot commented May 17, 2025

Uh oh!

github-actions Bot commented May 17, 2025

Uh oh!

paritytech-workflow-stopper Bot commented May 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

pgherveou commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pgherveou commented May 17, 2025

Uh oh!

pgherveou commented May 17, 2025

Uh oh!

github-actions Bot commented May 17, 2025

Uh oh!

github-actions Bot commented May 17, 2025

Uh oh!

pgherveou commented May 17, 2025

Uh oh!

github-actions Bot commented May 17, 2025

Uh oh!

github-actions Bot commented May 17, 2025

Uh oh!

paritytech-workflow-stopper Bot commented May 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pgherveou commented May 16, 2025 •

edited

Loading